progress: change ascii decoding to utf-8 for localized languages in dulwich backend #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
reviewed
Dec 13, 2021
skshetry
changed the title
Collaborator
|
@kwon-young, could you please do the following: pip install nox
nox -s lintAnd, add/commit the changes, please. This project is very young, so we don't have contributing guidelines yet, really sorry for the inconvenience. |
Contributor
Author
|
done |
skshetry
approved these changes
Dec 14, 2021
Collaborator
skshetry
left a comment
skshetry
left a comment
There was a problem hiding this comment.
Thanks, @kwon-young for the contributions. We have tests missing for the progress which I'll handle later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #16