Skip to content

Conversation

@pmrowla
Copy link
Contributor

@pmrowla pmrowla commented Mar 23, 2023

Closes #211

  • Clean workspace on stash.push is now handled properly for all backends
  • When checking is_dirty or status, the check is done within the same backend, which eliminates inconsistencies when mixing status + stash calls across different backends

(This PR does not address the lack of gitattributes support in dulwich)

@pmrowla pmrowla self-assigned this Mar 23, 2023
@pmrowla pmrowla force-pushed the stash-no-changes branch 3 times, most recently from 8e2e453 to 2df703d Compare March 23, 2023 09:14
@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2023

Codecov Report

Patch coverage: 70.00% and project coverage change: +0.06 🎉

Comparison is base (62ac00d) 82.35% compared to head (f752282) 82.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
+ Coverage   82.35%   82.41%   +0.06%     
==========================================
  Files          25       25              
  Lines        3559     3572      +13     
  Branches      622      626       +4     
==========================================
+ Hits         2931     2944      +13     
+ Misses        532      531       -1     
- Partials       96       97       +1     
Impacted Files Coverage Δ
src/scmrepo/git/backend/base.py 80.88% <ø> (ø)
src/scmrepo/git/stash.py 83.33% <0.00%> (ø)
src/scmrepo/git/backend/gitpython.py 64.80% <40.00%> (+0.28%) ⬆️
src/scmrepo/git/backend/dulwich/__init__.py 81.85% <100.00%> (+0.08%) ⬆️
src/scmrepo/git/backend/pygit2.py 78.27% <100.00%> (+0.14%) ⬆️
tests/test_stash.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pmrowla pmrowla force-pushed the stash-no-changes branch 4 times, most recently from 8ab5ed6 to f752282 Compare March 23, 2023 09:46
@pmrowla pmrowla merged commit 9919db8 into treeverse:main Mar 23, 2023
@pmrowla pmrowla deleted the stash-no-changes branch March 23, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

exp run: can't stash changes (nothing to stash) on Win

2 participants