Skip to content

Conversation

@pmrowla
Copy link
Contributor

@pmrowla pmrowla commented Mar 31, 2023

closes #225

@pmrowla pmrowla self-assigned this Mar 31, 2023
@pmrowla pmrowla force-pushed the credential-askpass branch 3 times, most recently from 1530283 to f9e759f Compare March 31, 2023 08:34
@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2023

Codecov Report

Patch coverage: 63.63% and project coverage change: -0.07 ⚠️

Comparison is base (b97d042) 81.25% compared to head (0d2d54d) 81.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
- Coverage   81.25%   81.19%   -0.07%     
==========================================
  Files          27       27              
  Lines        3814     3940     +126     
  Branches      668      692      +24     
==========================================
+ Hits         3099     3199     +100     
- Misses        608      623      +15     
- Partials      107      118      +11     
Impacted Files Coverage Δ
src/scmrepo/git/credentials.py 57.68% <53.08%> (+5.48%) ⬆️
tests/test_credentials.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pmrowla pmrowla force-pushed the credential-askpass branch from f9e759f to 0d2d54d Compare March 31, 2023 08:46
@pmrowla
Copy link
Contributor Author

pmrowla commented Mar 31, 2023

GIT_ASKPASS integration looks like this in vscode:

2023-03-31.17-43-07.mp4

Example uses dvc get in the vscode terminal, but it would be the same if you ran an experiment that had an import in the pipeline

(the initial window fadeout is vscode opening a separate window asking if I want to login via the github vscode extension, if user logs in through the github extension it would skip prompting for username/password)

@pmrowla pmrowla merged commit 697b946 into treeverse:main Mar 31, 2023
@pmrowla pmrowla deleted the credential-askpass branch March 31, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

git-credential follow ups

2 participants