pygit2: fix posixpath conversion from windows on is_ignored #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we were converting windows path to posixpath, the values were not in effect because we were not setting it to the variable. Also fixes #11, which unskips on Windows + pygit2 backend, which was due to the above bug.
Collaborator
Author
|
Test failures are unrelated, see #27. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we were converting windows path to posixpath, the values
were not in effect because we were not setting it to the
variable.
Also fixes #11, which unskips on Windows + pygit2 backend, which
was due to the above bug.