Skip to content

pygit2: fix posixpath conversion from windows on is_ignored #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2022
Merged

pygit2: fix posixpath conversion from windows on is_ignored #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scmrepo/git/backend/pygit2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ def _get_stash(self, ref: str):
def is_ignored(self, path: "Union[str, os.PathLike[str]]") -> bool:
rel = relpath(path, self.root_dir)
if os.name == "nt":
rel.replace("\\", "/")
rel = rel.replace("\\", "/")
return self.repo.path_is_ignored(rel)

def set_ref(
Expand Down
3 changes: 0 additions & 3 deletions tests/test_git.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,9 +720,6 @@ def test_ignore(tmp_dir: TmpDir, scm: Git, git: Git):


def test_ignored(tmp_dir: TmpDir, scm: Git, git: Git, git_backend: str):
if os.name == "nt" and git_backend == "pygit2":
pytest.skip()

tmp_dir.gen({"dir1": {"file1.jpg": "cont", "file2.txt": "cont"}})
tmp_dir.gen({".gitignore": "dir1/*.jpg"})

Expand Down