Remove async selector policy after fsspec #423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shcheklein
force-pushed
the
remove_selector_policy
branch
from
7b7d00b to
63c72a2
Compare
shcheklein
force-pushed
the
remove_selector_policy
branch
4 times, most recently
from
1a6d95b to
d74a83d
Compare
shcheklein
force-pushed
the
remove_selector_policy
branch
from
84b41c8 to
a2841eb
Compare
shcheklein
changed the title
shcheklein
commented
Jul 17, 2025
|
|
||
|
|
||
| @pytest.mark.skip_git_backend("pygit2", "gitpython") | ||
| @pytest.mark.skip_git_backend("pygit2", "gitpython", "dulwich") |
Contributor
Author
There was a problem hiding this comment.
Need to get back to it, some asserts fail here cc @skshetry (dulwich regression?)
shcheklein
added a commit
that referenced
this pull request
Jul 17, 2025
* [pre-commit.ci] pre-commit autoupdate updates: - [github.com/astral-sh/ruff-pre-commit: v0.11.13 → v0.12.3](astral-sh/ruff-pre-commit@v0.11.13...v0.12.3) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * ignore PLC0415 - we need a lot of those for perf reason * fix mypy * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix type in backend func * Update __init__.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Remove async selector policy after fsspec (#423) * try remove async selector policy after fsspec * skip dulwic test for gitignore, needs research --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Ivan Shcheklein <shcheklein@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mind: it goes on top of the
pre-commit-ci-update-configbranch / PR that has also some mypy fixes, but fails bc of these issues:Fixes #422
Fixes treeverse/dvc#10807
Context fsspec/filesystem_spec#1861
There is a separate issue with gitignore test (regression in dulwich?), but let's unblock the repo first - too many issues at once ...