status: add warning on slow status call #45
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Also see treeverse/dvc#7471 |
Contributor
|
We probably should just submit an upstream patch to optimize dulwich (basically the current default in dulwich behaves more like |
Contributor
Author
|
Good point, I'll have a look |
Contributor
Author
|
Opened jelmer/dulwich#956, will open a new one here when/if that is merged |
efiop
changed the title
Contributor
Author
|
Getting rid of this, ended up implenting Peter's suggestion in #69 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While playing with
dvc exp, I noticed that it would take a huge amount of time before getting any output.I tracked this down to
dvc/repo/experiments/__init__.py#L401: aself.scm.status()was taking a long time because of a large untracked directory (.venvvirtualenv folder).This is a kinda naive patch that prints a warning whenever it takes more than 10s for status to return. I don't intend for this to be merged, rather to be a starting point for a discussion.