Skip to content

Conversation

@pmrowla
Copy link
Contributor

@pmrowla pmrowla commented Mar 28, 2022

  • When selecting a backend to use for a given git call, we will now try the most recently used backend first, before trying the remaining backends
  • If we are switching backends, close the previously used backend before making the git call w/new backend

Should fix treeverse/dvc#7458

@pmrowla pmrowla self-assigned this Mar 28, 2022
for backend in self.initialized.values():
backend._reset() # pylint: disable=protected-access

def move_to_end(self, key: str, last: bool = True):
Copy link
Contributor Author

@pmrowla pmrowla Mar 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could just make this move_to_head() and get rid of the last option (since that's all we will ever use), but I went with this for now to stay consistent with the OrderedDict call

@pmrowla pmrowla marked this pull request as ready for review March 30, 2022 04:44
@pmrowla pmrowla merged commit 49024b9 into treeverse:main Mar 30, 2022
@pmrowla pmrowla deleted the pygit-merge-nfs branch March 30, 2022 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

exp run: cannot clean up temp directory runs on Linux + NFS

1 participant