Update on push_refspec and fetch_refspec (#58) #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: treeverse#58 1. Unify the API of `push_refspec` and `fetch_refspec`. 2. Can push multi `refspec` for one time. 3. No repository Error handle for `fetch_refspec` 4. Now the `push_refspec` and `fetch_refspec` will return the status for each refspec. Co-authored-by:
karajan1001
commented
Apr 15, 2022
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| class SyncStatus(Enum): |
Contributor
Author
There was a problem hiding this comment.
Not sure if there are better solutions for returning the status of push/pull
pmrowla
reviewed
Apr 15, 2022
pmrowla
reviewed
Apr 15, 2022
| progress: Callable[["GitProgressEvent"], None] = None, | ||
| **kwargs, | ||
| ): | ||
| ) -> Mapping[str, int]: |
Contributor
There was a problem hiding this comment.
SyncStatus should also be defined in base.py, and this should be Mapping[str, SyncStatus]
karajan1001
force-pushed
the
fix58
branch
2 times, most recently
from
1f5b150 to
e2a39e4
Compare
pmrowla
reviewed
Apr 18, 2022
karajan1001
force-pushed
the
fix58
branch
4 times, most recently
from
09f75ee to
89dcf4b
Compare
2 tasks
pmrowla
suggested changes
Apr 20, 2022
Contributor
pmrowla
left a comment
pmrowla
left a comment
There was a problem hiding this comment.
A couple minor fixes but otherwise LGTM
1. rename `push_refspec` to `push_refspecs` as it can receive a list of refspecs 2. Move SyncEnum to base.py 3. Modify abstract methods args of `push_refspecs` and `fetch_refspecs` to match the new api.
Co-authored-by: Peter Rowlands (변기호) <peter@pmrowla.com>
pmrowla
approved these changes
Apr 25, 2022
Contributor
|
There seem to be different names in scmrepo and in dvc. We have push_refspecs here, while we use push_refspec (without s) at the end in dvc. |
efiop
reviewed
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #58
push_refspecandfetch_refspec.refspecfor one time.fetch_refspecpush_refspecandfetch_refspecwill return the status for each refspec.