Skip to content

Conversation

@mattseddon
Copy link
Contributor

@mattseddon mattseddon commented May 21, 2022

We've run into this a couple of times now. The easiest thing to do is just add an eslint rule 👍🏻 .

@mattseddon mattseddon self-assigned this May 21, 2022
@mattseddon mattseddon requested a review from wolmir May 21, 2022 03:07
@mattseddon mattseddon marked this pull request as ready for review May 21, 2022 03:07
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 689e66a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.8% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@wolmir wolmir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattseddon mattseddon merged commit 0381d61 into main May 21, 2022
@mattseddon mattseddon deleted the add-etc-no-commented-out-code branch May 21, 2022 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants