Only pull selected files if they include the invoked path #1963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks, @mattseddon ! Separate Q: I don't remember (and if we have ticket)- what do we depend on to not pass the whole directory content when we pull it as a target? |
Contributor
Author
Will be done when we get the updated |
rogermparent
approved these changes
Jul 1, 2022
|
Code Climate has analyzed commit e576ca3 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.5% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1939.
This PR addresses #1939 by using the same rules that the Explorer tree uses to invoke context menu actions when right-clicking with multiple items selected.
Details of the logic implemented are here.
Demo
Screen.Recording.2022-07-01.at.11.03.55.am.mov