Add storybook-addon-themes #2016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 0460ce7 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.7% (0.1% change). View more on Code Climate. |
rogermparent
force-pushed
the
storybook-addon-themes
branch
from
0460ce7 to
15cdc03
Compare
mattseddon
approved these changes
Jul 13, 2022
Contributor
mattseddon
left a comment
mattseddon
left a comment
There was a problem hiding this comment.
Would be good to add some more of the default themes + One Dark Pro before merging.
Contributor
Author
|
Added some more default themes, here's the current list
Video updated with new themes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
storybook-theme-demo.mp4
This PR adds color themes to Storybook, allowing the developer to preview the Light and Dive Bar themes in Storybook on top of the normal dark theme.
These themes are just scraped from VSCode's dev tools by grabbing every rule that sets CSS variables and tossing it into a conditional classname that the plugin adds UI for toggling.