Skip to content

Upgrade vsce #2108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 27, 2022
Merged

Upgrade vsce #2108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25dc729
Upgrade VSCE
mattseddon Jul 27, 2022
ea7ef64
Merge branch 'main' into upgrade-vsce
mattseddon Jul 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion extension/.vscodeignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,17 @@
node_modules
.cache/**
.turbo/**
.vscode-test/**
.wdio-vscode-service/**
coverage/**
node_modules/**
scripts/**
src/**
.eslintrc.js
.gitignore
.prettierignore
.lintstagedrc.js
.vscodeignore
jest.config.js
tsconfig.json
webpack.config.ts
yarn.lock
Copy link
Contributor Author

@mattseddon mattseddon Jul 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After upgrading...

With old setup:

image

With this:

image

4 changes: 2 additions & 2 deletions extension/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1492,7 +1492,7 @@
"lint": "run-p 'lint:*'",
"dev": "shx rm -rf dist && tsc -watch -p ./",
"build": "yarn webpack --mode production",
"package": "vsce package --yarn -o ./dvc.vsix",
"package": "node ./scripts/ensureYarnLock.js && yarn run vsce package --yarn -o ./dvc.vsix",
"test-build": "tsc -p .",
"test-vscode": "node ./dist/test/runTest.js",
"test-e2e": "wdio run ./src/test/e2e/wdio.conf.ts",
Expand Down Expand Up @@ -1556,7 +1556,7 @@
"sinon-chai": "3.7.0",
"ts-jest": "28.0.7",
"ts-loader": "9.3.1",
"vsce": "2.9.2",
"vsce": "2.10.0",
"vscode-uri": "3.0.3",
"wdio-vscode-service": "3.0.3",
"webdriverio": "7.20.7",
Expand Down
6 changes: 6 additions & 0 deletions extension/scripts/ensureYarnLock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
const { resolve } = require('path')
const { ensureFileSync } = require('fs-extra')

const yarnLock = resolve(__dirname, '..', 'yarn.lock')

ensureFileSync(yarnLock)
Copy link
Contributor Author

@mattseddon mattseddon Jul 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[F] Added this instead of using touch for mythical 🪟s contributors.

8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17716,10 +17716,10 @@ vm-browserify@^1.0.1:
resolved "https://registry.yarnpkg.com/vm-browserify/-/vm-browserify-1.1.2.tgz#78641c488b8e6ca91a75f511e7a3b32a86e5dda0"
integrity sha512-2ham8XPWTONajOR0ohOKOHXkm3+gaBmGut3SRuu75xLd/RRaY6vqgh8NBYYk7+RW3u5AtzPQZG8F10LHkl0lAQ==

vsce@2.9.2:
version "2.9.2"
resolved "https://registry.yarnpkg.com/vsce/-/vsce-2.9.2.tgz#be5d2ca5899f31ba84225d6b19ea1376589df897"
integrity sha512-xyLqL4U82BilUX1t6Ym2opQEa2tLGWYjbgB7+ETeNVXlIJz5sWBJjQJSYJVFOKJSpiOtQclolu88cj7oY6vvPQ==
vsce@2.10.0:
version "2.10.0"
resolved "https://registry.yarnpkg.com/vsce/-/vsce-2.10.0.tgz#19a9f070ec319e26d4f23567f32826f48fc694aa"
integrity sha512-b+wB3XMapEi368g64klSM6uylllZdNutseqbNY+tUoHYSy6g2NwnlWuAGKDQTYc0IqfDUjUFRQBpPgA89Q+Fyw==
dependencies:
azure-devops-node-api "^11.0.1"
chalk "^2.4.2"
Expand Down