Skip to content

Add option to sort by starred experiments #2169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Add option to sort by starred experiments #2169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion extension/src/experiments/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,9 @@ export class Experiments extends BaseRepository<TableData> {

public async addSort() {
const columns = this.columns.getTerminalNodes()
const sortToAdd = await pickSortToAdd(columns)
const columnLikes = addStarredToColumns(columns)

const sortToAdd = await pickSortToAdd(columnLikes)
if (!sortToAdd) {
return
}
Expand Down
4 changes: 2 additions & 2 deletions extension/src/experiments/model/sortBy/quickPick.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ import { definedAndNonEmpty } from '../../../util/array'
import { quickPickManyValues, quickPickValue } from '../../../vscode/quickPick'
import { Title } from '../../../vscode/title'
import { Toast } from '../../../vscode/toast'
import { ColumnLike } from '../../columns/like'
import { pickFromColumnLikes } from '../../columns/quickPick'
import { Column } from '../../webview/contract'

export const pickSortToAdd = async (columns: Column[]) => {
export const pickSortToAdd = async (columns: ColumnLike[] | undefined) => {
const picked = await pickFromColumnLikes(columns, {
title: Title.SELECT_PARAM_OR_METRIC_SORT
})
Expand Down