Skip to content

Show min tested version in toast warning message #2209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2022
Merged

Show min tested version in toast warning message #2209

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06e3a11
Show min tested version in warning message
mattseddon Aug 18, 2022
eb63c4f
Merge branch 'main' into show-min-tested
mattseddon Aug 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extension/src/cli/version.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ const warnIfAheadOfLatestTested = (
) as ParsedSemver

if (currentMajor === latestTestedMajor && currentMinor > latestTestedMinor) {
Toast.warnWithOptions(`The located DVC CLI is at least a minor version ahead of the latest version the extension was tested with.
Toast.warnWithOptions(`The located DVC CLI is at least a minor version ahead of the latest version the extension was tested with (${LATEST_TESTED_CLI_VERSION}).
This could lead to unexpected behaviour.
Please upgrade to the most recent version of the extension and reload this window.`)
}
Expand Down