Skip to content

Add new stop queue action #3054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 7, 2023
Merged

Add new stop queue action #3054

merged 3 commits into from
Jan 7, 2023

Conversation

@mattseddon
Copy link
Contributor

@mattseddon mattseddon commented Jan 5, 2023 •
edited
Loading

1/2 main <- this <- #3059

Demo

Screen.Recording.2023-01-06.at.2.33.29.pm.mov

@mattseddon mattseddon added the product PR that affects product label Jan 5, 2023
@mattseddon mattseddon self-assigned this Jan 5, 2023
@mattseddon mattseddon force-pushed the add-queue-actions branch 2 times, most recently from b265db0 to ebf2f74 Compare January 5, 2023 04:58
@mattseddon mattseddon mentioned this pull request Jan 6, 2023
Merged
@mattseddon mattseddon changed the title Add new queue actions (stop and kill) Add new stop queue action Jan 6, 2023
@mattseddon mattseddon marked this pull request as ready for review January 6, 2023 03:55
@mattseddon mattseddon requested a review from shcheklein January 6, 2023 04:35
julieg18
julieg18 approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

extension/package.json
},
{
"command": "dvc.stopExperimentsQueue",
"when": "dvc.commands.available && dvc.project.available"
Copy link
Contributor

@julieg18 julieg18 Jan 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stop queue command is always available even when the queue isn't running. Would we want the command to only be available when the queue is running?

Copy link
Contributor Author

@mattseddon mattseddon Jan 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would need to interrogate dvc queue status to know whether or not there is anything running as the information is not readily available from exp show (queue can be started outside of VS Code, e.g in a terminal). It is essentially a no-op when the queue is not running. For now, this is good enough.

@mattseddon mattseddon enabled auto-merge (squash) January 7, 2023 00:31
@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Jan 7, 2023

Code Climate has analyzed commit bb95168 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.4% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit d483fa9 into main Jan 7, 2023
@mattseddon mattseddon deleted the add-queue-actions branch January 7, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shcheklein shcheklein Awaiting requested review from shcheklein

2 more reviewers

@sroy3 sroy3 sroy3 approved these changes

@julieg18 julieg18 julieg18 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mattseddon mattseddon

Labels

product PR that affects product

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mattseddon @sroy3 @julieg18