Clean up table file structure #3706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julieg18
approved these changes
Apr 19, 2023
Contributor
There was a problem hiding this comment.
Should commitsAndBranches be outside of the table folder since it's below the table?
Contributor
Author
There was a problem hiding this comment.
It's being moved inside with the multiple branches stuff
mattseddon
approved these changes
Apr 20, 2023
added 2 commits
April 20, 2023 09:40
|
Code Climate has analyzed commit d3630ec and detected 6 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 97.8% (85% is the threshold). This pull request will bring the total coverage in the repository to 94.8% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't want you to review this with the multiple branches in the table feature. Just cleaned up a little before adding the feature.
bodysubfolder intable.componentsfolder`.rows.map => TableBodyto its own file (where the main change is going to happen later)WorkspaceRowGroupfromTableBodyto its own component.I could really go into the deep end, trying to fix the codeclimate issues and making smaller CSS modules, but I'll stop at this for now.