Fix emacs local variable one-liners #454
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple of issues.
Issue 1:
AttributeErrorbeing raised when specifying some extras via emacs local variablesThis error happened because the
self.footnotesdictionary is created by theself.reset()function, which is called BEFORE the emacs local variables get parsed. This means that theself.footnotesdictionary doesn't get created because, when it is called, the footnotes extra has not been specified.This PR puts the
self.footnotesdict creation (and some other extras setup) into a separate_setup_extrasfunction which gets called duringself.reset()and after the emacs local variables are parsed.Issue 2: Emacs local variables appearing in the HTML output
Previously, an emacs one-liner would be parsed but have no changes made to it, meaning that it would appear in the final HTML.
This PR changes this so that these one-liners get automatically wrapped in HTML comments, so the output looks more like this: