Fix AssertionError hashing HTML blocks spread over multiple lines (#686)#687
Merged
nicholasserra merged 2 commits intotrentm:masterfrom Mar 12, 2026
Merged
Conversation
e1b8dff to
a53a611
Compare
Contributor
Author
|
Root cause seems to be bf0a1e2 where the In both iterations the simple tag check regex is tripped up by the sample given, so the function thinks that the tag is "closed". However the extra dilligence in the new one catches that: |
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #686.
We were using a regex to look for HTML tags, but not accounting for newlines. Used
re.Sflag to account for that