Skip to content

Hotfix/ansible documentation#160

Merged
abravosuse merged 2 commits into
latestfrom
hotfix/ansible-documentation
Mar 25, 2026
Merged

Hotfix/ansible documentation#160
abravosuse merged 2 commits into
latestfrom
hotfix/ansible-documentation

Conversation

@abravosuse
Copy link
Copy Markdown
Collaborator

Back porting ansible documentation to latest branch so that it gets published in Trento official documentation site.

@abravosuse abravosuse requested a review from EMaksy March 23, 2026 09:50
@EMaksy
Copy link
Copy Markdown
Member

EMaksy commented Mar 23, 2026

Hey @abravosuse, thanks for taking care, just be carefull we must merge the branch against latest not main :)
image

So when opening up a pr you need to pick latest,currently it is main :)

As this is only one commit and the latest commit, we can refer to this steps, without bumping up the antora version.
https://www.trento-project.io/docs/developer/trento-docs-site/collaboration-docs-team/docs-git-workflow.html#_2_publishing_a_new_release

Maybe i need to refresh ab it this document :)

@abravosuse
Copy link
Copy Markdown
Collaborator Author

abravosuse commented Mar 23, 2026

@EMaksy
Copy link
Copy Markdown
Member

EMaksy commented Mar 23, 2026

In the end both works :)
The main important thing is to merge against latest :)

@abravosuse
Copy link
Copy Markdown
Collaborator Author

So can we reuse this PR for latest or do I need to close it and open a new one?

@abravosuse abravosuse changed the base branch from main to latest March 23, 2026 13:53
@abravosuse
Copy link
Copy Markdown
Collaborator Author

@EMaksy I have changed the target branch for this PR. Are we good now?

Copy link
Copy Markdown
Member

@EMaksy EMaksy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay i took the liberty to add the latest change. You followed the guide perfectly :)
Ready to merge!

@abravosuse abravosuse merged commit c14b7b6 into latest Mar 25, 2026
5 checks passed
@abravosuse abravosuse deleted the hotfix/ansible-documentation branch March 25, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants