Fix roar get: populate git fields on job records#127
Merged
Conversation
TrevorBasinger
force-pushed
the
cg/fix-get-git-fields
branch
from
de9ddb8 to
9c8b47d
Compare
roar get created job records without git_commit, git_branch, or git_repo, causing GLaaS registration to fail with HTTP 400. - Resolve git commit, branch, and remote URL in get_artifacts - Add git_commit, git_branch, git_repo, step_name params to LocalJobRecorder.record() and pass them to db.jobs.create() - Also pass step_name to db.jobs.create() (was missing) - Thread step_name from GetRequest through to the recorder Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
TrevorBasinger
force-pushed
the
cg/fix-get-git-fields
branch
from
9c8b47d to
7f738bf
Compare
TrevorBasinger
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
roar getcreated job records withoutgit_commit,git_branch, orgit_repo, causing GLaaS registration to fail with HTTP 400 (request validation failed).The git commit was resolved but only stored in the nested metadata JSON, not on the job record itself. The GLaaS API requires the top-level git fields.
Changes
get_artifactsgit_commit,git_branch,git_repo,step_nameparams toLocalJobRecorder.record()db.jobs.create()Test plan
roar get <url>followed byroar register @Nsucceedsroar show @Nshows git info on get jobs-nstep name