refactor: [caches/memory] drop "referenced object" support #925
Draft
crandles wants to merge 3 commits intotrickstercache:mainfrom
Draft
refactor: [caches/memory] drop "referenced object" support #925crandles wants to merge 3 commits intotrickstercache:mainfrom
crandles wants to merge 3 commits intotrickstercache:mainfrom
Conversation
Signed-off-by: Chris Randles <randles.chris@gmail.com>
Signed-off-by: Chris Randles <randles.chris@gmail.com>
Member
|
re: references. For the memory cache, this will add a marshal immediately before every Store and an unmarshal immediately after every Retrieve, and those get more expensive as a time series object gets bigger (has more timestamps and/or series). Just want to double check that the CPU utilization doesn't go nuts as a result. The goal was that if many users are viewing the same dashboard with a fast auto-refresh that we're not repeatedly serializing/deserializing the identical payload over and over. |
Contributor
Author
|
sure, let me spin up a before and after load test (along with a before ristretto) I had something going with k6 somewhere, let me revisit that. with any luck the singleflight layer assists us there, but we could perhaps use that at another level |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Changes:
new panels:

more new panels: