Rewrite .fold() into something that is immediately readable
#1052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to the first matching counterexample)
squell
changed the title
.fold() into something that is immediately readable
Member
Author
|
(Sorry for the branch name, I thought I could rename that later.) |
bjorn3
reviewed
Mar 28, 2025
bjorn3
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1036, rewriting the
.fold().Commits are done step-by-step to show that the rewrite behaves equivalently (except for 75554ac, but that is fixed in the final beautiful result).
You can review this commit by commit (this will show you my "I'm not trying to be clever" careful editing of the code), but you can also just look at the final result which will be very easy to review.
Obviously we're going to squash these commits.
A hearty thanks to @cikzh for rubber ducking.