Don't open /dev/tty twice #1344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
force-pushed
the
refactor_pam_rpassword
branch
from
d5ec9d6 to
c169523
Compare
There is no need to do so and this refactor clarifies exactly when HiddenInput::new() returns Some. With this we no longer disable feedback on /dev/tty when we are reading a password from a pipe and we disable feedback on the correct tty if stdin is a different tty than /dev/tty. Once we implement askpass this also prevents interfering with the askpass program if it reads from the tty.
bjorn3
force-pushed
the
refactor_pam_rpassword
branch
from
c169523 to
19d6db4
Compare
This is necessary for askpass as with askpass the prompt is passed to the askpass program rather than directly printed to stdout.
squell
reviewed
Nov 19, 2025
Member
|
See my suggestions here: bjorn3#6 I think we are on the same page except that the |
bjorn3
force-pushed
the
refactor_pam_rpassword
branch
from
7107f02 to
295d4f7
Compare
Member
|
Sorry, didn't run |
squell
approved these changes
Nov 19, 2025
Member
squell
left a comment
squell
left a comment
There was a problem hiding this comment.
Fixing the tests is trivial, the rest looks good (it's nice that all the critical input path now goes through the same code paths)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to do so and this refactor clarifies exactly when HiddenInput::new() returns Some. With this we no longer disable feedback on /dev/tty when we are reading a password from a pipe and we disable feedback on the correct tty if stdin is a different tty than /dev/tty. Once we implement askpass this also prevents interfering with the askpass program if it reads from the tty.