Skip to content

Conversation

@nicktrn
Copy link
Collaborator

@nicktrn nicktrn commented Dec 1, 2025

  • use newer turbo
  • explicit pnpm v10
  • fix pnpm deploy via --legacy

@changeset-bot
Copy link

changeset-bot bot commented Dec 1, 2025

⚠️ No Changeset found

Latest commit: 1c65a7a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 1, 2025

Walkthrough

The pull request updates the supervisor service's Containerfile with tooling and build optimization changes. It upgrades turbo prune from v1.10.9 to v2.5.4, updates pnpm to version 10.23.0, adds pnpm store caching during the dependency-fetcher stage using cache mounts, and introduces the --legacy flag to the pnpm deploy command in both builder stages. Additionally, dumb-init is preserved in the base image for improved process signal handling.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify turbo v2.5.4 compatibility with the monorepo pruning strategy for the supervisor scope
  • Confirm pnpm@10.23.0 compatibility and any breaking changes versus the previous version
  • Review the implications of the --legacy flag in pnpm deploy and its necessity
  • Validate the pnpm fetch cache mount configuration and its impact on build performance and reproducibility
  • Confirm dumb-init's presence serves the intended signal-handling and zombie-reaping improvements

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete. It lacks required sections from the template: issue reference, checklist, testing details, changelog, and screenshots. Only a brief bullet-point summary is provided. Add missing template sections including issue reference, completed checklist, testing description, and changelog entry to meet repository contribution standards.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title directly references the main change: fixing supervisor image builds with pnpm v10, which aligns with the primary objectives of explicitly specifying pnpm v10 and fixing deployment.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/supervisor-image

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 485782c and 1c65a7a.

📒 Files selected for processing (1)
  • apps/supervisor/Containerfile (3 hunks)
🧰 Additional context used
🧠 Learnings (4)
📓 Common learnings
Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-27T16:27:48.098Z
Learning: pnpm version `10.23.0` and Node.js version `20.11.1` are required for development
📚 Learning: 2025-11-27T16:27:48.098Z
Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-27T16:27:48.098Z
Learning: pnpm version `10.23.0` and Node.js version `20.11.1` are required for development

Applied to files:

  • apps/supervisor/Containerfile
📚 Learning: 2025-11-27T16:27:48.098Z
Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-27T16:27:48.098Z
Learning: Use pnpm for package management in this monorepo

Applied to files:

  • apps/supervisor/Containerfile
📚 Learning: 2025-11-27T16:26:44.484Z
Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/executing-commands.mdc:0-0
Timestamp: 2025-11-27T16:26:44.484Z
Learning: Execute most monorepo commands using `pnpm run` from the root directory, with `--filter` flag for specific packages (e.g., `pnpm run dev --filter webapp`)

Applied to files:

  • apps/supervisor/Containerfile
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (23)
  • GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (6, 8)
  • GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (7, 8)
  • GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (5, 8)
  • GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (8, 8)
  • GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (3, 8)
  • GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (1, 8)
  • GitHub Check: units / internal / 🧪 Unit Tests: Internal (7, 8)
  • GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (4, 8)
  • GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (2, 8)
  • GitHub Check: units / internal / 🧪 Unit Tests: Internal (2, 8)
  • GitHub Check: units / internal / 🧪 Unit Tests: Internal (8, 8)
  • GitHub Check: units / internal / 🧪 Unit Tests: Internal (6, 8)
  • GitHub Check: units / internal / 🧪 Unit Tests: Internal (1, 8)
  • GitHub Check: units / internal / 🧪 Unit Tests: Internal (4, 8)
  • GitHub Check: units / internal / 🧪 Unit Tests: Internal (5, 8)
  • GitHub Check: units / internal / 🧪 Unit Tests: Internal (3, 8)
  • GitHub Check: units / packages / 🧪 Unit Tests: Packages (1, 1)
  • GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - pnpm)
  • GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
  • GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
  • GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - npm)
  • GitHub Check: typecheck / typecheck
  • GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (3)
apps/supervisor/Containerfile (3)

19-19: LGTM! Aligns with project requirements.

Explicitly pinning pnpm to version 10.23.0 using corepack ensures consistency across builds and matches the project's development requirements.

Based on learnings, pnpm version 10.23.0 is required for development.


40-40: The --legacy flag in pnpm deploy is a standard pnpm v10 feature that forces the legacy deploy implementation, disabling the new lockfile creation behavior introduced in v10. This is appropriate for deployment compatibility when a workspace may not have inject-workspace-packages=true configured. The flag usage here is correct.


8-8: Test the pruned monorepo output against turbo v2's changed lockfile parsing for pnpm.

The prune command and its flags (--scope, --docker) remain supported in turbo v2.5.4, but v2 changes how lockfiles are parsed and handled for pnpm. This can affect which transitive dependencies end up in the pruned output. Since this Dockerfile is also pinning pnpm@10.23.0 and adding a --legacy flag to the deploy step, verify that the pruned lockfile semantics work correctly with pnpm v10 before merging. Test locally by running turbo prune --scope=supervisor --docker and comparing the resulting lockfile against v1 output.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@myftija myftija enabled auto-merge (squash) December 1, 2025 11:16
@myftija myftija disabled auto-merge December 1, 2025 11:16
@nicktrn nicktrn merged commit 2bf86dc into main Dec 1, 2025
31 checks passed
@nicktrn nicktrn deleted the fix/supervisor-image branch December 1, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants