Skip to content

Conversation

@myftija
Copy link
Collaborator

@myftija myftija commented Dec 5, 2025

We recently upgraded the ECR sdk version. Our ECR repo exists check relies on the type of the error thrown and the new ECR sdk version seems to have broken that behavior. This PR adds a workaround to the issue.

We recently upgraded the ECR sdk version. Our ECR repo exists check relies on the type of the error thrown and the new ECR sdk version seems to have broken that behavior. This PR adds a workaround to the issue.
@changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2025

⚠️ No Changeset found

Latest commit: ca45ea5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 5, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The change modifies the error handling in the getEcrRepository function within getDeploymentImageRef.server.ts. The catch block now evaluates errors as "not found" scenarios using two conditions: checking if the error is an instance of RepositoryNotFoundException or if the error message contains "does not exist". When either condition is true, the function returns undefined; otherwise, the error is rethrown. No public API signatures were modified.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Focus area: Verify that the string matching logic ("does not exist") is case-sensitive and accurately captures all ECR error message variations
  • Focus area: Confirm that broadening the error catch condition does not inadvertently mask unrelated errors that should propagate
  • Focus area: Review whether both condition branches (exception type check and message check) are mutually exclusive or if there is intentional overlap
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-repo-exists-check

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d8f5853 and ca45ea5.

📒 Files selected for processing (1)
  • apps/webapp/app/v3/getDeploymentImageRef.server.ts (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@myftija myftija merged commit d1c3bfb into main Dec 5, 2025
27 of 28 checks passed
@myftija myftija deleted the fix-repo-exists-check branch December 5, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants