Fix/check initialised #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertjan
commented
Sep 10, 2018
| if (typeof thingToWrap != "function") { | ||
| if (typeof thingToWrap !== "function") { | ||
| if (!thingToWrap[__isinitialised__]) { | ||
| throw new Error(`cannot call "${name}" outside "draw", "setup" or event handlers`); |
Contributor
Author
There was a problem hiding this comment.
@eah13 you might want to think about the wording of this error. And we might want to throw a real python exception here. But which one?
Member
There was a problem hiding this comment.
throw a real python exception
I can't think of an appropriate one. I don't think you'd encounter an analogous situation in Python.
We could invent a new exception ala SuspensionError, perhaps ProcessingError?
brianpmarks
reviewed
Sep 11, 2018
Member
brianpmarks
left a comment
brianpmarks
left a comment
There was a problem hiding this comment.
Looks good to me! There are conflicts on the built files though so maybe previous PRs need to be pulled into this branch?
Contributor
Author
|
Yeah I'll merge and rebuild. |
albertjan
force-pushed
the
fix/check-initialised
branch
from
14ba1fb to
4762866
Compare
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
throws an error message if a function is called before processing is initialised.
See: http://albertjan-dev.trinket.io/python/9f0110db88