Add support for pruning splits using metadata columns in Delta Lake #25376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenjian2664
force-pushed
the
delta_file_time
branch
from
afe9cba to
f77b4b2
Compare
chenjian2664
commented
Mar 21, 2025
| public void testOptimizeWithFileModifiedTimeColumn() | ||
| throws Exception | ||
| { | ||
| try (TestTable table = newTrinoTable("test_optimize_with_file_modified_time_", "(id INT)")) { |
Contributor
Author
There was a problem hiding this comment.
The tests are copied from BaseIcebergConnectorTest with very small changes:
- using MILLISECONDS.sleep(1);
- adapt the result
getActiveFiles - using
newTrinoTableto create test table
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java
Outdated
Show resolved
Hide resolved
ebyhr
reviewed
Mar 24, 2025
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeSplitManager.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeSplitManager.java
Outdated
Show resolved
Hide resolved
chenjian2664
force-pushed
the
delta_file_time
branch
from
f77b4b2 to
f82ffa5
Compare
findinpath
reviewed
Mar 24, 2025
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java
Outdated
Show resolved
Hide resolved
chenjian2664
force-pushed
the
delta_file_time
branch
from
f82ffa5 to
b165d68
Compare
findinpath
reviewed
Mar 24, 2025
plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeConnectorTest.java
Outdated
Show resolved
Hide resolved
findinpath
reviewed
Mar 24, 2025
plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeConnectorTest.java
Outdated
Show resolved
Hide resolved
findinpath
approved these changes
Mar 24, 2025
chenjian2664
force-pushed
the
delta_file_time
branch
from
48fac61 to
1923e8f
Compare
chenjian2664
changed the title
chenjian2664
force-pushed
the
delta_file_time
branch
from
1923e8f to
36b985c
Compare
Member
|
@chenjian2664 Could you confirm CI failure? |
chenjian2664
force-pushed
the
delta_file_time
branch
from
36b985c to
47d3648
Compare
ebyhr
reviewed
Mar 25, 2025
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeSplitManager.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeConnectorTest.java
Outdated
Show resolved
Hide resolved
chenjian2664
force-pushed
the
delta_file_time
branch
4 times, most recently
from
3481036 to
b1008c0
Compare
ebyhr
reviewed
Mar 27, 2025
Member
ebyhr
left a comment
ebyhr
left a comment
There was a problem hiding this comment.
This PR still has a correctness issue on DELETE operation. You can reproduce by the following steps:
CREATE TABLE test(a int);
INSERT INTO test VALUES 1;
INSERT INTO test VALUES 2;
SELECT "$path" FROM test;
DELETE FROM test WHERE "$path" = 'x'; -- removes all rows
TABLE test;
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/util/DeltaLakeUtil.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeColumnHandle.java
Outdated
Show resolved
Hide resolved
Extracted `partitionMatchesPredicate` from `DeltaLakeSplitManager` into a new utility class `DeltaLakeDomains`
chenjian2664
force-pushed
the
delta_file_time
branch
2 times, most recently
from
144888b to
ef439e4
Compare
Co-Authored-By: Marius Grama <findinpath@gmail.com>
The `$path` column is already used for pruning splits in DeltaLakeSplitManager, This commit removes the `$path` domain from `remainingFilter` of the filter pushdown result Co-Authored-By: Marius Grama <findinpath@gmail.com>
chenjian2664
force-pushed
the
delta_file_time
branch
from
ef439e4 to
26d17a1
Compare
Co-Authored-By: Marius Grama <findinpath@gmail.com>
Member
|
(Fixed a small typo) |
ebyhr
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces handling and pushdown of the metadata columns('$file_modified_time', '$path', '$file_size') in Delta Lake
Description
Closes #25369
Release notes