Rewrite exclude_columns to Projection to apply optimizations #25388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takezoe
force-pushed
the
rewrite-exclude-columns
branch
from
077d54d to
d064acd
Compare
takezoe
force-pushed
the
rewrite-exclude-columns
branch
from
d064acd to
300d7b6
Compare
kasiafi
reviewed
Mar 29, 2025
Member
kasiafi
left a comment
kasiafi
left a comment
There was a problem hiding this comment.
@takezoe thank you for your effort.
Please note that the mapping of projected columns to output symbols is determined by the requiredSymbols property.
Also, we should match the function by the ConnectorTableFunctionHandle rather than by the function name.
Please refer to this code: https://github.com/trinodb/trino/compare/master...kasiafi:544ExcludeColumnsToProject?expand=1 It solves the same issue, I just never opened a PR.
Member
Author
|
@kasiafi Great thanks! Yours should be used. |
Member
Author
|
I hope that @kasiafi will create a PR from his branch. Enabling pushdown through |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rewrite
exclude_columnsto projection not to block optimizationsAdditional context and related issues
#25117
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: