[WIP] Add support for periodically refreshing dynamic catalogs from the CatalogStore #25389
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Proposal to add support for Trino installations using dynamic catalogs to periodically refresh catalogs from the configured
CatalogStore. It allows Trino to periodically list the catalogs available in theCatalogStoreand add/remove/update the available catalogs accordingly.The objective of this proposed change is to allow administrators to externally manage dynamic catalogs and have Trino periodically sync to their configuration, rather than needing to push catalog changes to Trino through
CREATE/DROP CATALOGstatements.Catalog refreshes are disabled by default and can be enabled through the
catalog.refresh.enabledconfiguration property. The refresh interval defaults to 60 seconds and can be configured through thecatalog.refresh.refresh-intervalExample configuration:
I would love to hear feedback on whether this change is welcome and on the approach itself. I would also appreciate any recommendations on how to effectively test the change.
Additional context and related issues
Catalog refreshes are implemented in the
CoordinatorDynamicCatalogManager::refreshCatalogs()method. The approach is to list the catalogs from the catalog store, compare them to the currently active catalogs and determine the catalogs that were added, removed or updated. With that information, update the catalog state accordingly.Catalog refreshing is triggered by the
CatalogRefreshTask, which works very similarly to the existingCatalogPruneTask.Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
(x) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: