Fix flaky TestLokiIntegration.testSelectTimestampLogsQuery #25438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
requested changes
Mar 27, 2025
Member
ebyhr
left a comment
ebyhr
left a comment
There was a problem hiding this comment.
Thanks for sending this PR, but the test is still flaky.
Please run stress tests with @RepeatedTest on your laptop.
jeschkies
force-pushed
the
karsten/flake
branch
from
d96a841 to
5bdf2e3
Compare
Member
Author
|
@ebyhr thanks. I ran it with 100 iterations and it was fine. |
ebyhr
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Loki query was selecting the second line of the test data. This is because the timestamp for the first line and start of the query were the same. All other tests move the timestamps for each line away from the start and end to avoid such a flake.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:
Fixes #25035