Skip to content

Conversation

@raunaqmorarka
Copy link
Member

Description

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

Copilot finished reviewing on behalf of raunaqmorarka November 25, 2025 08:51
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs minor cleanups around PageBuilderStatus by removing the unused no-arg constructor and updating its usages across the codebase. The changes simplify the API and align test code with best practices.

  • Removed the no-arg constructor from PageBuilderStatus class
  • Updated test code to pass null for BlockBuilderStatus where page size tracking is not needed
  • Migrated tests that verify page fullness behavior to use PageBuilder directly instead of PageBuilderStatus

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
core/trino-spi/src/main/java/io/trino/spi/block/PageBuilderStatus.java Removed the no-arg constructor that was no longer needed
core/trino-spi/src/main/java/io/trino/spi/PageBuilder.java Updated documentation to remove reference to non-existent newPageBuilderLike() method
core/trino-spi/src/test/java/io/trino/spi/block/TestVariableWidthBlockBuilder.java Migrated test to use PageBuilder for testing page fullness behavior
core/trino-spi/src/test/java/io/trino/spi/block/TestArrayBlockBuilder.java Migrated test to use PageBuilder for testing page fullness behavior
lib/trino-parquet/src/test/java/io/trino/parquet/writer/BenchmarkLongColumnWriter.java Simplified block builder creation by passing null instead of creating unnecessary PageBuilderStatus
lib/trino-parquet/src/test/java/io/trino/parquet/writer/BenchmarkBinaryColumnWriter.java Simplified block builder creation by passing null instead of creating unnecessary PageBuilderStatus
core/trino-main/src/test/java/io/trino/type/TestLikePatternType.java Simplified block builder creation by passing null instead of creating unnecessary PageBuilderStatus
core/trino-main/src/test/java/io/trino/sql/planner/TestDeleteAndInsertMergeProcessor.java Simplified block builder creation by passing null instead of creating unnecessary PageBuilderStatus
core/trino-main/src/test/java/io/trino/operator/output/TestPositionsAppender.java Refactored test helper methods to validate size directly on BlockBuilder instead of through PageBuilderStatus
core/trino-main/src/main/java/io/trino/operator/scalar/ArrayCombinationsFunction.java Simplified block builder creation by passing null instead of creating unnecessary PageBuilderStatus

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@raunaqmorarka raunaqmorarka merged commit 2529320 into trinodb:master Nov 25, 2025
195 of 198 checks passed
@raunaqmorarka raunaqmorarka deleted the page-bb-cleanup branch November 25, 2025 17:03
@github-actions github-actions bot added this to the 479 milestone Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants