Skip to content

Remove salt from HKDF in internal communication#28096

Merged
wendigo merged 1 commit intomasterfrom
user/serafin/remove-salt
Feb 3, 2026
Merged

Remove salt from HKDF in internal communication#28096
wendigo merged 1 commit intomasterfrom
user/serafin/remove-salt

Conversation

@wendigo
Copy link
Contributor

@wendigo wendigo commented Feb 3, 2026

Description

Addresses @losipiuk @findepi concerns

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Feb 3, 2026
@wendigo wendigo requested review from findepi and losipiuk February 3, 2026 15:54
@findepi
Copy link
Member

findepi commented Feb 3, 2026

Description

Addresses @losipiuk @findepi concerns

Let's try to capture something more objective, if possible

@wendigo
Copy link
Contributor Author

wendigo commented Feb 3, 2026

@findepi I don't remember what was it 😅

On hypothethical Trino version mismatch, new node joining a cluster
will get unathorized exception which doesn't say much about the issue
and could be confusing to end users.
@wendigo wendigo force-pushed the user/serafin/remove-salt branch from 635210b to bdb14fd Compare February 3, 2026 19:15
@wendigo wendigo merged commit b34757c into master Feb 3, 2026
3 of 13 checks passed
@wendigo wendigo deleted the user/serafin/remove-salt branch February 3, 2026 19:15
@github-actions github-actions bot added this to the 480 milestone Feb 3, 2026
@ebyhr ebyhr mentioned this pull request Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants