Skip to content

Enhanced attribute handling#25

Merged
trippwill merged 2 commits intomainfrom
deep-attributes
May 29, 2024
Merged

Enhanced attribute handling#25
trippwill merged 2 commits intomainfrom
deep-attributes

Conversation

@trippwill
Copy link
Owner

  • Updated methods in JsonSchemaBuilderExtensions.cs for better attribute data retrieval and handling of SchemaItemsRangeAttribute.
  • Added new methods in JsonSchemaBuilderExtensions.cs, MemberInfoExtensions.cs, and TypeExtensions.cs for improved functionality.
  • Removed ArrayTypeHandler from AggregateTypeHandler.cs and deleted ArrayTypeHandler.cs file.
  • Updated EnumAsStringTypeHandler.cs, EnumerableTypeHandler.cs, and OverrideValueTypeHandler.cs to handle definitions and references.
  • Added new file SchemaItemsRangeAttribute.cs for specifying schema items range.

* Updated methods in `JsonSchemaBuilderExtensions.cs` for better attribute data retrieval and handling of `SchemaItemsRangeAttribute`.
* Added new methods in `JsonSchemaBuilderExtensions.cs`, `MemberInfoExtensions.cs`, and `TypeExtensions.cs` for improved functionality.
* Removed `ArrayTypeHandler` from `AggregateTypeHandler.cs` and deleted `ArrayTypeHandler.cs` file.
* Updated `EnumAsStringTypeHandler.cs`, `EnumerableTypeHandler.cs`, and `OverrideValueTypeHandler.cs` to handle definitions and references.
* Added new file `SchemaItemsRangeAttribute.cs` for specifying schema items range.
@codecov
Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 55.43478% with 41 lines in your changes are missing coverage. Please review.

Project coverage is 75.34%. Comparing base (8db6800) to head (1306658).
Report is 3 commits behind head on main.

Files Patch % Lines
src/SharpSchema/JsonSchemaBuilderExtensions.cs 34.78% 14 Missing and 1 partial ⚠️
src/SharpSchema/MemberInfoExtensions.cs 60.71% 8 Missing and 3 partials ⚠️
.../SharpSchema/TypeHandlers/EnumerableTypeHandler.cs 66.66% 3 Missing and 2 partials ⚠️
...arpSchema.Annotations/SchemaItemsRangeAttribute.cs 0.00% 3 Missing ⚠️
...harpSchema/TypeHandlers/EnumAsStringTypeHandler.cs 70.00% 2 Missing and 1 partial ⚠️
...arpSchema/TypeHandlers/OverrideValueTypeHandler.cs 66.66% 2 Missing and 1 partial ⚠️
src/SharpSchema/StringExtensions.cs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
- Coverage   76.83%   75.34%   -1.49%     
==========================================
  Files          37       37              
  Lines        1092     1144      +52     
  Branches      151      164      +13     
==========================================
+ Hits          839      862      +23     
- Misses        208      231      +23     
- Partials       45       51       +6     
Flag Coverage Δ
LinuxHost 75.34% <55.43%> (-1.49%) ⬇️
Release 75.34% <55.43%> (-1.49%) ⬇️
WindowsHost 75.34% <55.43%> (-1.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trippwill trippwill merged commit b1b8dca into main May 29, 2024
@trippwill trippwill deleted the deep-attributes branch November 3, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant