Add assert_pending tests and fix Logger.enable#1
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds unit tests for the util.assert_pending helper and corrects the parameter validation logic in Logger:enable.
- Introduces tests covering both matching and mismatched absolute file paths for
util.assert_pending - Adjusts
Logger:enableto properly validate its parameters (not shown in this diff)
Comments suppressed due to low confidence (1)
tests/swapdiff/util_spec.lua:75
- It would strengthen the test to assert on the specific error message, ensuring it clearly indicates the mismatch between expected and actual absolute file paths.
assert.is_truthy(err)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
util.assert_pendingLogger:enableTesting
/tmp/nvim-linux-x86_64/bin/nvim --headless -u NONE -c 'set rtp+=/tmp/plenary' -c 'runtime plugin/plenary.vim' -c 'PlenaryBustedDirectory tests/' -c 'qa'https://chatgpt.com/codex/tasks/task_e_68442bb414e4832e9e14fc610d3a25d0