Use 'Display::fmt' instead of 'Error::description', fix warnings#286
Merged
trishume merged 2 commits intoMar 31, 2020
Merged
Conversation
Contributor
Author
|
Note that using |
trishume
approved these changes
Mar 31, 2020
Owner
trishume
left a comment
There was a problem hiding this comment.
Cool thanks for cleaning this up
Owner
|
I just released this and your other PR as v4.1.0 |
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error::descriptionhas been deprecated in Rust 1.42: https://doc.rust-lang.org/stable/std/error/trait.Error.html#method.descriptionWhen compiling
syntectwith the latest compiler, error messages look like this:With this fix, we can see the reason for error messages again:
I also fixed the other two remaining warnings concerning superfluous parentheses.