feat: add specification of waypoint laps #307
Merged
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AskewParity
force-pushed
the
feat/waypoint-laps
branch
from
64d257f to
e6ce238
Compare
kimichenn
approved these changes
Oct 31, 2025
Contributor
kimichenn
left a comment
kimichenn
left a comment
There was a problem hiding this comment.
lgtm. We probably want to implement some sort of lap counter and send it down to the gcs so we know which lap we're on. But this can be left as an exercise to the reader.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #293.
I'm not very happy with my implementation. The issue is how
FlyWaypointsis initialized. It is a generalized tick, and how it is implemented means that you have to specify the next tick.I also haven't implemented to spec