Skip to content

Use new MPI custom ops in mpi reduce#2066

Draft
benegee wants to merge 26 commits intomainfrom
bg/custom_ops_macro_in_mpi_reduce
Draft

Use new MPI custom ops in mpi reduce#2066
benegee wants to merge 26 commits intomainfrom
bg/custom_ops_macro_in_mpi_reduce

Conversation

@benegee
Copy link
Contributor

@benegee benegee commented Sep 5, 2024

Follow-up to #2054

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

@codecov
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.77%. Comparing base (cec533a) to head (65385b1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2066   +/-   ##
=======================================
  Coverage   96.76%   96.77%           
=======================================
  Files         521      521           
  Lines       42456    42458    +2     
=======================================
+ Hits        41082    41085    +3     
+ Misses       1374     1373    -1     
Flag Coverage Δ
unittests 96.77% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DanielDoehring DanielDoehring added the parallelization Related to MPI, threading, tasks etc. label Sep 6, 2024
@benegee
Copy link
Contributor Author

benegee commented Sep 6, 2024

@vchuravy got it working!

Despite one single very strange error involving vectorization... see CI.

Base automatically changed from bg/base_min_in_mpi_reduce to main September 13, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parallelization Related to MPI, threading, tasks etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants