feat(configure): add repo_subdir support for monorepo deployments#14
Merged
feat(configure): add repo_subdir support for monorepo deployments#14
Conversation
Adds --repo-subdir CLI option and repo_subdir config key so the service root (WorkingDirectory, venv, exec_start probe) can target a subdirectory of the cloned repo instead of the repo root. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
hailangvn
approved these changes
Apr 13, 2026
Collaborator
hailangvn
left a comment
There was a problem hiding this comment.
I think we should change update command as well as in separated commit.
nilshamerlinck
commented
Apr 13, 2026
deploy/command/update.py
Outdated
Comment on lines
+140
to
+143
| executor.run( | ||
| "if [ -f addons/repos.yaml ]; then cd addons/ && gitaggregate -c repos.yaml; fi", | ||
| cwd=instance_path, | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
@hailangvn why not under eff_type == "odoo" only anymore?
Collaborator
There was a problem hiding this comment.
In configure command the git aggregate is outside of eff_type so it should be same with update command. No?
Contributor
Author
There was a problem hiding this comment.
better fix configure command then as this is odoo specific
Collaborator
There was a problem hiding this comment.
It has been fixed. Thank you.
Contributor
Author
There was a problem hiding this comment.
thanks, I think you can merge then
20c2214 to
f0ce239
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--repo-subdirCLI option toconfigurecommandrepo_subdirkey support indeploy.ymlconfig.envcopy, build command,WorkingDirectory, andvenv_pathall resolve relative to the subdirectory instead of the repo rootgitaggregatestill operate on the repo root (unchanged)Example
With
repo_subdir: pythonindeploy.yml(or--repo-subdir python), the generated unit becomes:Test plan
--repo-subdir <subdir>and verifyWorkingDirectoryandExecStartpaths in the generated.servicefile--repo-subdirand verify existing behaviour is unchangedrepo_subdirindeploy.ymland verify it is picked up without the CLI flagmake checkandmake test— all pass🤖 Generated with Claude Code