fix to treat JsonNull as no type (type = null) #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yas-okadatech
commented
Jun 10, 2025
| } | ||
| else if(elem.isJsonNull()) { | ||
| result.put(key, null); | ||
| } |
There was a problem hiding this comment.
ここを入れる前は、280行目 result.put(key, elem) が実行され、JsonNullのインスタンスが設定されていました (そのため、JSONと判定される)
yas-okadatech
changed the title
yas-okadatech
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current code, JsonNull is treated as json.
If the first 50 records doesn't have values in a certain cell, "embulk guess" will treat the cell as json (guessed from JsonNull).
I fixed
JiraUtil.toLinkedHashMapto setnullif JSON's value is JsonNull.By this fix, type will be
null, then embulk-util-guess cannot handle type == null correctly due to a bug.ref: Fix guessing a timestamp format from null (Fix #25) by dmikurube · Pull Request #23 · embulk/embulk-util-guess
So I bumped embulk-util-guess to
0.2.0too in order to fix this bug.