Skip to content

fix to treat JsonNull as no type (type = null) #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025
Merged

fix to treat JsonNull as no type (type = null) #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ dependencies {
}
compile('org.embulk:embulk-util-retryhelper-jetty92:0.8.2')
compile 'org.embulk:embulk-util-timestamp:0.2.1'
compile('org.embulk:embulk-util-guess:0.1.2')
compile('org.embulk:embulk-util-guess:0.2.0')

compile('org.embulk:embulk-util-json:0.1.1') {
exclude group: 'com.fasterxml.jackson.core', module: 'jackson-core'
Expand Down
6 changes: 3 additions & 3 deletions gradle/dependency-locks/embulkPluginRuntime.lockfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,13 @@ org.eclipse.jetty:jetty-http:9.2.14.v20151106
org.eclipse.jetty:jetty-io:9.2.14.v20151106
org.eclipse.jetty:jetty-util:9.2.14.v20151106
org.embulk:embulk-util-config:0.3.1
org.embulk:embulk-util-file:0.1.1
org.embulk:embulk-util-guess:0.1.2
org.embulk:embulk-util-file:0.1.3
org.embulk:embulk-util-guess:0.2.0
org.embulk:embulk-util-json:0.1.1
org.embulk:embulk-util-retryhelper-jetty92:0.8.2
org.embulk:embulk-util-retryhelper:0.8.2
org.embulk:embulk-util-rubytime:0.3.2
org.embulk:embulk-util-text:0.1.0
org.embulk:embulk-util-text:0.1.1
org.embulk:embulk-util-timestamp:0.2.1
org.glassfish.hk2.external:javax.inject:2.5.0-b42
org.glassfish.hk2:osgi-resource-locator:1.0.1
Expand Down
3 changes: 3 additions & 0 deletions src/main/java/org/embulk/input/jira/util/JiraUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,9 @@ public static LinkedHashMap<String, Object> toLinkedHashMap(final JsonObject flt
if (elem.isJsonPrimitive()) {
result.put(key, flt.get(key).getAsString());
}
else if(elem.isJsonNull()) {
result.put(key, null);
}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここを入れる前は、280行目 result.put(key, elem) が実行され、JsonNullのインスタンスが設定されていました (そのため、JSONと判定される)

else {
result.put(key, elem);
}
Expand Down