feat!: Improve search/find methods #8
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
While integrating Payment Rails API with this library, I realized there are quite a few things missing. Mainly, the search (or find) methods have lots of attributes missing, and as we needed a way to get a specific recipient by email address, we decided to modify the SDK a little bit.
The new
UrlUtilsclass provides a method to automatically get all Python method parameters and convert them into a Payment Rails API equivalent. There is an example available atRecipientGateway.search: the only condition is that Python method attributes name have to match with PR API ones.Checklist