feat: add ENABLE_UPDATE_CHECKS and migrate ETag storage to database#707
feat: add ENABLE_UPDATE_CHECKS and migrate ETag storage to database#707IngmarStein merged 4 commits intomainfrom
Conversation
IngmarStein
commented
Jan 27, 2026
- Add ENABLE_UPDATE_CHECKS configuration option (defaulting to "1")
- Disable update checks globally in tests to avoid GitHub API rate limits
- Refactor firmware downloader to store ETag in the database settings instead of a local file
- use ETag for system update checks to reduce GitHub API quota usage
- Add ENABLE_UPDATE_CHECKS configuration option (defaulting to "1") - Disable update checks globally in tests to avoid GitHub API rate limits - Refactor firmware downloader to store ETag in the database settings instead of a local file - use ETag for system update checks
Summary of ChangesHello @IngmarStein, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new configuration setting to control update checks and refactors how ETags are managed for both firmware and system updates. By migrating ETag storage to the database and utilizing them for conditional requests, the system becomes more efficient in its API usage and provides better control over update mechanisms, especially in test environments. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a configuration option to enable/disable update checks and refactors ETag storage from local files to the database for both firmware and system updates. This is a good improvement for reducing GitHub API usage and centralizing state management. The changes in tests to disable update checks are also a good practice. I've identified a couple of areas in the system update check logic that could be made more robust by improving error handling and ensuring data consistency when reading/writing settings to the database.