Add background flag to handlePushImage and handlePushApp

[RamenLlama97]

Adds parity for the pixlet push -b, -background flag

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a mechanism to differentiate between foreground and background pushes for applications and images. By adding a background flag to the push request data, the system can now skip immediate WebSocket notifications for background operations, aligning with the functionality of the pixlet push -b command. This enhances flexibility in how content is delivered to devices, allowing for silent updates when real-time user interaction is not required.

Highlights

• API Structure Update: Added a new Background boolean field to both the PushAppData and PushData structs, allowing API requests to specify if a push should occur in the background.
• Conditional WebSocket Notifications: Modified the handlePushApp and handlePushImage functions to only send real-time WebSocket notifications to devices if the Background flag is not set (i.e., it's a foreground push).

Changelog

• internal/server/handlers_api.go
  • Added a Background boolean field to the PushAppData struct.
  • Modified the handlePushApp function to conditionally send WebSocket notifications based on the Background flag.
  • Added a Background boolean field to the PushData struct.
  • Modified the handlePushImage function to conditionally send WebSocket notifications based on the Background flag.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds a background flag to the handlePushApp and handlePushImage API endpoints, allowing images to be pushed without being immediately displayed on the device. The implementation is straightforward and correctly modifies the handlers to conditionally skip the websocket notification.

My review includes a couple of suggestions to improve error logging consistency and reduce code duplication, which will enhance maintainability.

[tavdog]

Looks simple enough. I'll test it tomrrow. Thanks.