feat: add option to show full app animation

[gabe565]

Adds an option to override show_full_animation for an app, allowing an app to be rendered for longer than the device's cycle time.

See #752

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new feature that provides granular control over how app animations are displayed. Previously, animations longer than the device's cycle time would be truncated. With this change, users can now configure individual applications to always play their full animation, regardless of the device's default cycle settings. This enhances the user experience by allowing more expressive and complete app animations.

Highlights

• Model Update: Introduced a ShowFullAnimation boolean field to the App data model, allowing individual apps to specify whether their full animation should be displayed.
• Rendering Logic Enhancement: Modified the core rendering function to accept and utilize the new showFullAnimation parameter, ensuring that app animations can override the device's cycle time.
• User Interface Integration: Added a new dropdown option in the app configuration page, enabling users to easily toggle the "Show Full Animation" setting for each app.
• Backend Handling: Implemented server-side logic to process the show_full_animation setting from the UI, store it in the database, and retrieve it for rendering.
• Internationalization: Included new translation strings for the "Show Full Animation" feature in both English and German.

Changelog

• internal/data/models.go
  • Added ShowFullAnimation *bool field to the App struct.
• internal/renderer/renderer.go
  • Updated the Render function signature to include showFullAnimation *bool and passed this value to the loader.WithShowFullAnimation option.
• internal/server/handlers_app.go
  • Modified handleConfigAppGet to pass ShowFullAnimationOptions to the template and handleConfigAppPost to parse and save the show_full_animation payload.
• internal/server/helpers.go
  • Defined ShowFullAnimationOption struct, added ShowFullAnimationOptions to TemplateData, and created getShowFullAnimationChoices to provide options for the UI.
• internal/server/render_utils.go
  • Updated RenderApp to retrieve the ShowFullAnimation setting from the app object and pass it to the renderer.Render function.
• web/i18n/de.json
  • Added German translations for "Show Full Animation", "ShowFullAnimationTooltip", "Auto (Chosen by the app)", "True", "False", and "Override whether the full animation is shown".
• web/i18n/en.json
  • Added English translations for "Show Full Animation", "ShowFullAnimationTooltip", "Auto (Chosen by the app)", "True", "False", and "Override whether the full animation is shown".
• web/templates/manager/configapp.html
  • Introduced a new select input for "Show Full Animation" in the app configuration form, including its label, tooltip, and options, and updated the JavaScript for form submission.

Activity

• No activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new option to allow an app's full animation to be shown, even if it exceeds the device's cycle time. The implementation is thorough, with changes spanning the data model, renderer, server handlers, and frontend templates, including internationalization support. A new ShowFullAnimation field has been added to the App model, and the UI in the app configuration page has been updated with a corresponding dropdown. The backend logic correctly handles the new setting during rendering and when saving the app configuration. The code is clean and adheres to the project's conventions. Overall, this is a well-executed feature addition.