Potential Deadlock fixed #123
Merged
zhaohong merged 1 commit intotronprotocol:developfrom Feb 13, 2018
sdargutev:develop
Merged
Potential Deadlock fixed #123zhaohong merged 1 commit intotronprotocol:developfrom sdargutev:develop
zhaohong merged 1 commit intotronprotocol:developfrom
sdargutev:develop
Conversation
… memory leak when calling this method multiple times.
Contributor
|
I've fixed this one before in #71, weird that the previous fix got reverted :/ The unittests you've added should ensure this bug won't fly under the radar again |
Contributor
|
@Rovak i'll check why got reverted @sdargutev thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a bug in LevelDbDataSourceImpl.closeDB, that can cause deadlock and memory leak when called multiple times.
Why are these changes required?
To avoid blocking threads and leaking memory.
This PR has been tested by:
Follow up
Extra details