optimize granularity of blockLock#4536
Merged
317787106 merged 2 commits intotronprotocol:release_v4.5.2from Jul 28, 2022
Merged
optimize granularity of blockLock#4536317787106 merged 2 commits intotronprotocol:release_v4.5.2from
317787106 merged 2 commits intotronprotocol:release_v4.5.2from
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4536 +/- ##
=============================================
- Coverage 54.23% 53.96% -0.28%
+ Complexity 7887 7848 -39
=============================================
Files 826 826
Lines 46785 46785
Branches 5075 5076 +1
=============================================
- Hits 25376 25247 -129
- Misses 19380 19516 +136
+ Partials 2029 2022 -7
Continue to review full report at Codecov.
|
xxo1shine
approved these changes
Jul 28, 2022
Collaborator
Author
|
optimize granularity of blockLock |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We introduce a solution to reduce the log error "Peer xxx not sync for a long time" when fullnode syncs with peer.
Why are these changes required?
ChannelManager.activePeers and SyncPool.activePeers is confusing, wo change ChannelManager.activePeers to ChannelManager.activeChannels.
This PR has been tested by:
Follow up
Extra details
tronprotocol/tips#427