Skip to content

fix(solidityNode): fix solidity node startup issue#4577

Merged
jwrct merged 2 commits intotronprotocol:release_v4.5.2from
jwrct:feature/optimize_blocks_processing
Aug 10, 2022
Merged

fix(solidityNode): fix solidity node startup issue#4577
jwrct merged 2 commits intotronprotocol:release_v4.5.2from
jwrct:feature/optimize_blocks_processing

Conversation

@jwrct
Copy link
Copy Markdown
Contributor

@jwrct jwrct commented Aug 9, 2022

What does this PR do?
solidity nodes no longer start peer server and discover server

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@lvs007 lvs007 requested a review from xxo1shine August 9, 2022 10:39
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #4577 (42eec0d) into release_v4.5.2 (dbc2524) will decrease coverage by 0.24%.
The diff coverage is 33.33%.

@@                 Coverage Diff                  @@
##             release_v4.5.2    #4577      +/-   ##
====================================================
- Coverage             54.25%   54.00%   -0.25%     
+ Complexity             7947     7917      -30     
====================================================
  Files                   831      831              
  Lines                 47094    47095       +1     
  Branches               5099     5100       +1     
====================================================
- Hits                  25549    25435     -114     
- Misses                19511    19641     +130     
+ Partials               2034     2019      -15     
Impacted Files Coverage Δ
...org/tron/common/overlay/server/ChannelManager.java 63.26% <0.00%> (ø)
...g/tron/common/overlay/discover/DiscoverServer.java 79.03% <50.00%> (+0.34%) ⬆️
...mmon/net/udp/message/discover/FindNodeMessage.java 0.00% <0.00%> (-95.00%) ⬇️
...mon/net/udp/message/discover/NeighborsMessage.java 0.00% <0.00%> (-93.75%) ⬇️
...n/common/net/udp/message/discover/PongMessage.java 0.00% <0.00%> (-90.00%) ⬇️
...core/exception/TransactionExpirationException.java 0.00% <0.00%> (-66.67%) ⬇️
...org/tron/common/overlay/discover/DiscoverTask.java 33.33% <0.00%> (-36.67%) ⬇️
...udp/message/discover/DiscoverMessageInspector.java 21.62% <0.00%> (-27.03%) ⬇️
...tron/common/overlay/discover/node/NodeHandler.java 51.56% <0.00%> (-22.66%) ⬇️
.../java/org/tron/common/net/udp/message/Message.java 56.52% <0.00%> (-13.05%) ⬇️
... and 10 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@jwrct jwrct merged commit 8b559ef into tronprotocol:release_v4.5.2 Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants