Skip to content

feat(db): remove method getValuesPrev#4602

Merged
halibobo1205 merged 1 commit intotronprotocol:developfrom
halibobo1205:feat/db_remove_getValuesPrev
Aug 23, 2022
Merged

feat(db): remove method getValuesPrev#4602
halibobo1205 merged 1 commit intotronprotocol:developfrom
halibobo1205:feat/db_remove_getValuesPrev

Conversation

@halibobo1205
Copy link
Copy Markdown
Collaborator

@halibobo1205 halibobo1205 commented Aug 22, 2022

What does this PR do?
1. this method is not used, and is wrong in some case
2. re-add correct method if it may be used in the future

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

 1. this method is not used, and is wrong in some case
 2. re-add correct method if it may be used in the future
@halibobo1205 halibobo1205 force-pushed the feat/db_remove_getValuesPrev branch from db0c39f to 8c0bf60 Compare August 23, 2022 05:57
@halibobo1205 halibobo1205 changed the title core(db): remove getValuesPrev. feat(db): remove method getValuesPrev Aug 23, 2022
Copy link
Copy Markdown
Contributor

@tomatoishealthy tomatoishealthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@halibobo1205 halibobo1205 merged commit 58f5e0b into tronprotocol:develop Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants