Skip to content

update CONTRIBUTING.md#4604

Merged
ethan1844 merged 2 commits intotronprotocol:developfrom
vivian1912:update-contribution-doc
Aug 22, 2022
Merged

update CONTRIBUTING.md#4604
ethan1844 merged 2 commits intotronprotocol:developfrom
vivian1912:update-contribution-doc

Conversation

@vivian1912
Copy link
Copy Markdown
Contributor

What does this PR do?
update commit message section of contribution doc
Why are these changes required?
make it more clear to illustrate how to write a committing message for a pull request
This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@vivian1912 vivian1912 changed the title Update CONTRIBUTING.md update CONTRIBUTING.md Aug 22, 2022
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #4604 (b2782b3) into develop (7f3ed0a) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #4604      +/-   ##
=============================================
- Coverage      54.24%   54.19%   -0.06%     
+ Complexity      7946     7938       -8     
=============================================
  Files            831      831              
  Lines          47120    47120              
  Branches        5103     5103              
=============================================
- Hits           25562    25537      -25     
- Misses         19528    19555      +27     
+ Partials        2030     2028       -2     
Impacted Files Coverage Δ
...n/common/net/udp/message/discover/PongMessage.java 0.00% <0.00%> (-90.00%) ⬇️
...mon/overlay/discover/table/DistanceComparator.java 80.00% <0.00%> (-20.00%) ⬇️
...tron/common/overlay/discover/node/NodeHandler.java 51.56% <0.00%> (-9.38%) ⬇️
...udp/message/discover/DiscoverMessageInspector.java 21.62% <0.00%> (-8.11%) ⬇️
.../java/org/tron/common/net/udp/message/Message.java 56.52% <0.00%> (-4.35%) ⬇️
.../tron/common/overlay/discover/table/NodeTable.java 90.76% <0.00%> (-3.08%) ⬇️
...ay/discover/node/statistics/MessageStatistics.java 91.24% <0.00%> (-2.92%) ⬇️
...tron/common/overlay/discover/node/NodeManager.java 73.68% <0.00%> (ø)
...mework/src/main/java/org/tron/core/db/Manager.java 55.99% <0.00%> (+0.62%) ⬆️
...re/metrics/blockchain/BlockChainMetricManager.java 70.00% <0.00%> (+2.50%) ⬆️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ethan1844 ethan1844 merged commit 0a7123a into tronprotocol:develop Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants